Data loading fix for [Part 1 - Basic Features]

spring-attic / tut-react-and-spring-data-rest

React.js and Spring Data REST :: A tutorial based on the 5-part blog series by Greg Turnquist

883 stars 1.58k forks source link

Closed dphov closed 6 years ago

dphov commented 7 years ago

Data loading fix for [Part 1 - Basic Features], Updating dependencies

pivotal-issuemaster commented 7 years ago

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 7 years ago

@dphov Thank you for signing the Contributor License Agreement!

gregturn commented 7 years ago

Thanks for the PR

With when.js, then must return another promise. You use done when there is nothing else to be done.
Your change only updates the "basic" version. It would be nice to update them all.
it's hard to read all the mods because you also changed all the formatting from tabs to spaces. I'd rather keep it the way it is. We can discuss that in a separate issue.

gregturn commented 6 years ago

This looks very nice except

you changed the spacing from tabs to double spaces. I'd like to not make such a visual change.
it only updates the basic module.