spring-cloud / spring-cloud-build

Common build concerns, shared plugin configuration, etc. for Spring Cloud modules
Apache License 2.0
191 stars 284 forks source link

Root pom references multiple maven plugins with milestone versions #210

Closed spencergibb closed 3 years ago

spencergibb commented 3 years ago

Releaser now fails with milestone versions, but for 2020.0.2 build was released before that fix happened.

Either we need to change them or add a way so release can ignore those.

https://github.com/spring-cloud/spring-cloud-build/blob/6a702ea4441eb76faf9559198eae5e40f642737b/pom.xml#L69

and

https://github.com/spring-cloud/spring-cloud-build/blob/6a702ea4441eb76faf9559198eae5e40f642737b/pom.xml#L75

marcingrzejszczak commented 3 years ago

I think that we should add some comment that would be checked in the same line. Sth like

<maven-surefire-report-plugin.version>3.0.0-M5</maven-surefire-report-plugin.version><!-- @releaser:version-check-off -->
spencergibb commented 3 years ago

yeah, the maven plugins don't matter.

marcingrzejszczak commented 3 years ago

Releaser code updated - https://github.com/spring-cloud/spring-cloud-release-tools/commit/4b6c8b375cd28ac992ebcd1dd23d9fb7ef8ee741