search

spring-cloud / spring-cloud-build

Common build concerns, shared plugin configuration, etc. for Spring Cloud modules
Apache License 2.0
191 stars 284 forks source link

Default Spring Boot version in 3.0.x should move to 2.5.x #224

Closed elefeint closed 2 years ago

elefeint commented 2 years ago

Currently 3.0.x branch of spring-cloud-build pulls in spring-boot-dependencies at version 2.4.13.

However, Spring Boot 2.4.x went out of support in November, so there likely won't be a 2.4.14. This is especially relevant given the log4j upgrade, which will be included in Spring Boot 2.5.8 but not in the 2.4.x branch.

Should Spring Cloud Build 3.0.x switch the Spring Boot version to 2.5.7 (and update to 2.5.8 when it comes out)?

A related question -- are you planning a 3.0.5 release after Spring Boot releases?

spencergibb commented 2 years ago

build 3.0.x supports both boot 2.4.x and 2.5.x. Uses don't get the spring boot version from spring cloud, so any log4j versions come with boot, not cloud.

elefeint commented 2 years ago

Got it; we should switch to managing Spring Boot version for building in Spring Cloud GCP directly, then. We still derived Spring Boot version from spring-cloud-dependencies for historical reasons.

Then it's just an FYI.

spencergibb commented 2 years ago

yes, that is a good idea since we may do things that may break you anyway.