search

spring-cloud / spring-cloud-build

Common build concerns, shared plugin configuration, etc. for Spring Cloud modules
Apache License 2.0
191 stars 284 forks source link

Remove lf from NewlineAtEndOfFileCheck #227

Closed artembilan closed 2 years ago

artembilan commented 2 years ago

Different OSs may check out files with different line separators. So, to better support other development environments it would be great to just require any end of file, not just Linux-specific.

spencergibb commented 2 years ago

Not sure about this one. Are you the one having the issue?

artembilan commented 2 years ago

I am, Spencer. I develop on Windows and my Git client checks out files with crlf, so when I try to build Spring Cloud projects, the Checkstyle fails for me that it expects only lf. It worked in the past because they really checked for end of line, which suited to crlf combination with just that lf config. But now it fails because the rule has been tightened a little bit.

See similar config in SF: https://github.com/spring-projects/spring-framework/blob/main/src/checkstyle/checkstyle.xml#L16. The respective change on their side: https://github.com/spring-projects/spring-framework/commit/2feedb98ccaad01d9c75073604a9c90956a33afb.

We do the same in Spring Integration, Spring AMQP, Spring for Apache Kafka.

See also this for more justifications: https://github.com/spring-io/spring-javaformat/issues/202

spencergibb commented 2 years ago

Thanks for the justifications.

spencergibb commented 2 years ago

Cherry picked to 3.1.x and merged forward via 711fbce9ba938f788426a0ff5cd455b8eff4ab0e