search

spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
329 stars 110 forks source link

ReactiveResilience4JCircuitBreaker missing support for configuration properties #107

Closed ThomasVitale closed 3 years ago

ThomasVitale commented 3 years ago

Configuration properties support was added to Resilience4JCircuitBreaker in #88. It would be useful to add the same for the reactive version.

Suggested solution: https://github.com/spring-cloud/spring-cloud-circuitbreaker/pull/108

timothymathison commented 3 years ago

Ironically, when I originally opened #61, I was looking for reactive support. So that issue wasn't fully resolved. Thanks for opening this 👍.

timothymathison commented 3 years ago

In the interim, I believe the suggested solution in https://github.com/spring-cloud/spring-cloud-circuitbreaker/issues/61#issuecomment-636414118 works. But properties should definitely be supported for both.

Also, #88 didn't add mapping correctly for instance specific properties. I believe that only the default properties are being mapped.