spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
329 stars 110 forks source link

Add properties support for reactive circuit breaker #108

Closed ThomasVitale closed 3 years ago

ThomasVitale commented 3 years ago

ReactiveResilience4JCircuitBreaker can now be configured through properties in the same way as its imperative counterpart.

Re-added documentation on how to work with configuration properties since the one added in #88 got lost.

Fixes gh-107

codecov[bot] commented 3 years ago

Codecov Report

Merging #108 (8f33af3) into main (72868b7) will decrease coverage by 2.94%. The diff coverage is 71.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #108      +/-   ##
============================================
- Coverage     86.52%   83.57%   -2.95%     
- Complexity       77       78       +1     
============================================
  Files            13       13              
  Lines           319      341      +22     
  Branches          8        8              
============================================
+ Hits            276      285       +9     
- Misses           37       50      +13     
  Partials          6        6              
Impacted Files Coverage Δ Complexity Δ
...e4j/ReactiveResilience4JCircuitBreakerFactory.java 76.66% <66.66%> (-13.34%) 9.00 <2.00> (+1.00) :arrow_down:
...silience4j/ReactiveResilience4JCircuitBreaker.java 75.00% <72.72%> (-17.86%) 7.00 <3.00> (ø)
...ience4j/ReactiveResilience4JAutoConfiguration.java 90.00% <100.00%> (ø) 3.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72868b7...8f33af3. Read the comment docs.

ryanjbaxter commented 3 years ago

ping @ThomasVitale

ryanjbaxter commented 3 years ago

I also cherry picked this into 1.0.x branch

ThomasVitale commented 3 years ago

Thanks @ryanjbaxter