spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
336 stars 110 forks source link

support group config on circutbreaker and timelimiter #117

Closed rodbate closed 2 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #117 (ef01015) into main (9c5473d) will decrease coverage by 5.70%. The diff coverage is 64.70%.

:exclamation: Current head ef01015 differs from pull request most recent head b8623bb. Consider uploading reports for the commit b8623bb to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #117      +/-   ##
============================================
- Coverage     83.57%   77.86%   -5.71%     
- Complexity       78       83       +5     
============================================
  Files            13       14       +1     
  Lines           341      366      +25     
  Branches          8       12       +4     
============================================
  Hits            285      285              
- Misses           50       77      +27     
+ Partials          6        4       -2     
Impacted Files Coverage Δ
...ience4j/ReactiveResilience4JAutoConfiguration.java 41.66% <0.00%> (-48.34%) :arrow_down:
...tbreaker/springretry/SpringRetryConfigBuilder.java 76.19% <0.00%> (ø)
...er/resilience4j/Resilience4JAutoConfiguration.java 50.00% <63.63%> (-46.00%) :arrow_down:
...ilience4j/Resilience4JConfigurationProperties.java 66.66% <66.66%> (ø)
...eaker/resilience4j/Resilience4JCircuitBreaker.java 66.66% <100.00%> (+1.96%) :arrow_up:
...esilience4j/Resilience4JCircuitBreakerFactory.java 80.43% <100.00%> (+1.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c5473d...b8623bb. Read the comment docs.

ryanjbaxter commented 2 years ago

This looks good. I think we need want to do the same for the reactive implementation as well?

rodbate commented 2 years ago

This looks good. I think we need want to do the same for the reactive implementation as well?

yeap. I would take a look and make it later