search

spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
336 stars 110 forks source link

Set a common group tag #130

Closed ryanjbaxter closed 2 years ago

ryanjbaxter commented 2 years ago

Fixes #121

This addresses an issue in micrometer where CB with different tags end up not showing up in the metrics. See https://github.com/micrometer-metrics/micrometer/issues/877

ryanjbaxter commented 2 years ago

@jonatan-ivanov would like your thoughts if you have any knowledge here.

If you think this looks OK, I would probably make this configurable as well as add a property to disable it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #130 (14fa251) into 2.1.x (8984e86) will increase coverage by 0.17%. The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.1.x     #130      +/-   ##
============================================
+ Coverage     77.39%   77.56%   +0.17%     
- Complexity       78       81       +3     
============================================
  Files            13       14       +1     
  Lines           345      361      +16     
  Branches         10       12       +2     
============================================
+ Hits            267      280      +13     
- Misses           74       77       +3     
  Partials          4        4
Impacted Files Coverage Δ
...ilience4j/Resilience4JConfigurationProperties.java 66.66% <66.66%> (ø)
...er/resilience4j/Resilience4JAutoConfiguration.java 50.00% <100.00%> (+12.96%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8984e86...14fa251. Read the comment docs.