search

spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
329 stars 110 forks source link

support group config on circutbreaker and timelimiter #133

Closed rodbate closed 2 years ago

rodbate commented 2 years ago

Add support group/service config on Reative&Blocked CircuitBreaker.

Descending priority from top to bottom.

ryanjbaxter commented 2 years ago

Can you provide some details on exactly what this PR is adding and or fixing in the description please?

codecov[bot] commented 2 years ago

Codecov Report

Merging #133 (f8eedff) into main (915dde1) will increase coverage by 1.90%. The diff coverage is 93.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #133      +/-   ##
============================================
+ Coverage     77.56%   79.46%   +1.90%     
- Complexity       81       90       +9     
============================================
  Files            14       14              
  Lines           361      375      +14     
  Branches         12       12              
============================================
+ Hits            280      298      +18     
+ Misses           77       73       -4     
  Partials          4        4
Impacted Files Coverage Δ
...silience4j/ReactiveResilience4JCircuitBreaker.java 83.33% <85.00%> (+8.33%) :arrow_up:
...e4j/ReactiveResilience4JCircuitBreakerFactory.java 82.92% <100.00%> (+6.26%) :arrow_up:
...eaker/resilience4j/Resilience4JCircuitBreaker.java 66.66% <100.00%> (+1.96%) :arrow_up:
...esilience4j/Resilience4JCircuitBreakerFactory.java 81.25% <100.00%> (+2.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 915dde1...f8eedff. Read the comment docs.

rodbate commented 2 years ago

Could you add some documentation?

OK, Added.

rodbate commented 2 years ago

If you could add some documentation to this file that would be great https://github.com/spring-cloud/spring-cloud-circuitbreaker/blob/main/docs/src/main/asciidoc/spring-cloud-circuitbreaker-resilience4j.adoc

Added