search

spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
328 stars 109 forks source link

some more clean-up in spring retry implementation #137

Closed wind57 closed 2 years ago

wind57 commented 2 years ago

some nitpicks here and there, to make the code cleaner.

codecov[bot] commented 2 years ago

Codecov Report

Merging #137 (4e0b1fb) into main (bc55843) will decrease coverage by 0.31%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #137      +/-   ##
============================================
- Coverage     80.52%   80.21%   -0.32%     
- Complexity      105      106       +1     
============================================
  Files            15       15              
  Lines           380      374       -6     
  Branches         14       14              
============================================
- Hits            306      300       -6     
  Misses           70       70              
  Partials          4        4
Impacted Files Coverage Δ
...breaker/springretry/SpringRetryCircuitBreaker.java 100.00% <ø> (ø)
.../springretry/SpringRetryCircuitBreakerFactory.java 83.33% <100.00%> (ø)
.../circuitbreaker/springretry/SpringRetryConfig.java 93.75% <100.00%> (ø)
...tbreaker/springretry/SpringRetryConfigBuilder.java 64.70% <100.00%> (-9.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc55843...4e0b1fb. Read the comment docs.

wind57 commented 2 years ago

@ryanjbaxter can you take a look here also - not much of a big deal, at least imho. thank you.