search

spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
336 stars 110 forks source link

Adds support for imperative resilience4j circuit breaker observations #150

Closed marcingrzejszczak closed 2 years ago

marcingrzejszczak commented 2 years ago

prerequisite: https://github.com/spring-cloud/spring-cloud-commons/pull/1131

marcingrzejszczak commented 2 years ago

Actually you don't need to enable this cause if you there's a ObservationRegistry bean on the classpath it will work out of the box.

ryanjbaxter commented 2 years ago

So this that a universal feature of observability across all projects?

marcingrzejszczak commented 2 years ago

This is a feature that adds observability for Resilience4j and will set a ObservationRegistry bean if it's present.

codecov[bot] commented 2 years ago

Codecov Report

Merging #150 (47d4fd2) into main (2162ab4) will increase coverage by 0.30%. The diff coverage is 92.85%.

@@             Coverage Diff              @@
##               main     #150      +/-   ##
============================================
+ Coverage     81.58%   81.88%   +0.30%     
- Complexity      114      117       +3     
============================================
  Files            15       15              
  Lines           391      403      +12     
  Branches         17       18       +1     
============================================
+ Hits            319      330      +11     
  Misses           69       69              
- Partials          3        4       +1
Impacted Files Coverage Δ
...er/resilience4j/Resilience4JAutoConfiguration.java 52.63% <75.00%> (+2.63%) :arrow_up:
...esilience4j/Resilience4JCircuitBreakerFactory.java 85.48% <100.00%> (+2.15%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.