search

spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
328 stars 109 forks source link

spring-boot-starter-aop missing #187

Closed mgimenoromanadevinta closed 6 days ago

mgimenoromanadevinta commented 1 week ago

Describe the bug Since org.springframework.cloud:spring-cloud-dependencies:2023.0.2 the dependency org.springframework.boot:spring-boot-starter-aop has been removed from org.springframework.cloud:spring-cloud-starter-openfeign.

This is causing this circuit breaker library to not work properly if it's not added manually into the build file (circuits are always closed, etc)

An issue was raised to openfeign and they answered that they don't plan to add it back and that it should be in the libraries that require it (in this case, this one it seems)

Is this something that you're aware of? Is there a plan to fix it?

Thank you very much

ryanjbaxter commented 6 days ago

Are you using Resilience4J annotations and that is why you need spring-boot-starter-aop? https://resilience4j.readme.io/docs/getting-started-3#annotations

mgimenoromanadevinta commented 6 days ago

Hello @ryanjbaxter

Yes indeed, we're using annotations such as @CircuitBreaker

ryanjbaxter commented 6 days ago

That is not functionality provided by Spring Cloud CircuitBreaker not Spring Cloud OpenFeign the requirement is coming from Resilience4J. So I do not believe we should be including the AOP started in the Spring Cloud projects.

mgimenoromanadevinta commented 5 days ago

Thanks for your answer @ryanjbaxter !