search

spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
336 stars 110 forks source link

Resilience4j bulkhead patterns #87

Closed Ferioney closed 3 years ago

Ferioney commented 3 years ago

added supporting of resilience4j bulkhead patterns Fixes gh-86

Ferioney commented 3 years ago

@ryanjbaxter I think we can also implement support of config files in this topic (similar to the Support Resilience4J Configuration Properties ). What do you think?

ryanjbaxter commented 3 years ago

@Ferioney This looks good just fix the merge conflicts.

I think we can also implement support of config files in this topic (similar to the Support Resilience4J Configuration Properties ). What do you think?

So you can configure bulkheads using configuration properties?

Ferioney commented 3 years ago

@ryanjbaxter I did some major changes in PR, please review again. Main changes:

  1. Added support of properties file for Bulkheads.
  2. Changed default bulkhead implementation from Semaphone to ThreadPool. My team and I think it more relevant for people who are going to migrate from Hystrix to Resilience4j.
  3. Changed default behavior of property spring.cloud.bulkhead.resilience4j.enable