search

spring-cloud / spring-cloud-circuitbreaker

Spring Cloud Circuit Breaker API and Implementations
Apache License 2.0
329 stars 110 forks source link

CirciutBreaker/TimeLimiter/Bulkheads should use default Resilience4j properties configuration #94

Closed Ferioney closed 3 years ago

Ferioney commented 3 years ago

Spring Boot Resilience4j provides default properties configuration:

resilience4j.circuitbreaker:
    configs:
        default:
            slidingWindowSize: 100
            permittedNumberOfCallsInHalfOpenState: 10

To my mind, this configuration should be used as default instead of CircuitBreakerConfig.ofDefaults().

eduardo-bueno-ifood commented 3 years ago

Should be considered a bug because they're read by resilience4j components, but disregarded at the Resilience4JCircuitBreakerFactory configuration.