search

spring-cloud / spring-cloud-cli

Spring Cloud CLI features
Apache License 2.0
155 stars 80 forks source link

3.0.0 config server not launching #172

Closed dsyer closed 3 years ago

dsyer commented 3 years ago 
Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2021-01-20 16:24:41.297 ERROR 17427 --- [       Thread-1] o.s.b.d.LoggingFailureAnalysisReporter   : 

***************************
APPLICATION FAILED TO START
***************************

Description:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

    org.apache.catalina.authenticator.AuthenticatorBase.startInternal(AuthenticatorBase.java:1355)

The following method did not exist:

    'java.lang.String javax.servlet.ServletContext.getVirtualServerName()'

The method's class, javax.servlet.ServletContext, is available from the following locations:

    jar:file:/home/dsyer/.m2/repository/javax/servlet/servlet-api/2.5/servlet-api-2.5.jar!/javax/servlet/ServletContext.class
    jar:file:/home/dsyer/.m2/repository/org/apache/tomcat/embed/tomcat-embed-core/9.0.41/tomcat-embed-core-9.0.41.jar!/javax/servlet/ServletContext.class

The class hierarchy was loaded from the following locations:

    javax.servlet.ServletContext: file:/home/dsyer/.m2/repository/javax/servlet/servlet-api/2.5/servlet-api-2.5.jar

Action:

Correct the classpath of your application so that it contains a single, compatible version of javax.servlet.ServletContext
ryanjbaxter commented 3 years ago

What version of Spring Boot are you using?

dsyer commented 3 years ago

2.4.2. But it shouldn't matter - the app that fails is the configserver and it is self-contained in its own classpath, I think.

spencergibb commented 3 years ago

Similar if not a duplicate of #171

spencergibb commented 3 years ago

So if I look at the dependencies of config-server servlet-api:2.5 isn't a direct or transitive dependency of spring-cloud-config-server.

Running wrapper at /home/spencer/workspace/spring/spring-cloud-config
Running version check
The found version is [3.0.2-SNAPSHOT]
Deactivating "milestone" profile for version="3.0.2-SNAPSHOT"
Deactivating "central" profile for version="3.0.2-SNAPSHOT"
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.springframework.cloud:spring-cloud-config-server:jar:3.0.2-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.codehaus.mojo:flatten-maven-plugin is missing. @ org.springframework.cloud:spring-cloud-config:3.0.2-SNAPSHOT, /home/spencer/workspace/spring/spring-cloud-config/pom.xml, line 203, column 12
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Building spring-cloud-config-server 3.0.2-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ spring-cloud-config-server ---
[INFO] org.springframework.cloud:spring-cloud-config-server:jar:3.0.2-SNAPSHOT
[INFO] +- org.springframework.boot:spring-boot-configuration-processor:jar:2.4.2-SNAPSHOT:compile
[INFO] +- org.springframework.boot:spring-boot-starter-jdbc:jar:2.4.2-SNAPSHOT:compile
[INFO] |  +- org.springframework.boot:spring-boot-starter:jar:2.4.2-SNAPSHOT:compile
[INFO] |  |  +- org.springframework.boot:spring-boot:jar:2.4.2-SNAPSHOT:compile
[INFO] |  |  +- org.springframework.boot:spring-boot-starter-logging:jar:2.4.2-SNAPSHOT:compile
[INFO] |  |  |  +- ch.qos.logback:logback-classic:jar:1.2.3:compile
[INFO] |  |  |  |  \- ch.qos.logback:logback-core:jar:1.2.3:compile
[INFO] |  |  |  +- org.apache.logging.log4j:log4j-to-slf4j:jar:2.13.3:compile
[INFO] |  |  |  |  \- org.apache.logging.log4j:log4j-api:jar:2.13.3:compile
[INFO] |  |  |  \- org.slf4j:jul-to-slf4j:jar:1.7.30:compile
[INFO] |  |  \- jakarta.annotation:jakarta.annotation-api:jar:1.3.5:compile
[INFO] |  +- com.zaxxer:HikariCP:jar:3.4.5:compile
[INFO] |  \- org.springframework:spring-jdbc:jar:5.3.3:compile
[INFO] |     \- org.springframework:spring-tx:jar:5.3.3:compile
[INFO] +- org.springframework.boot:spring-boot-starter-data-redis:jar:2.4.2-SNAPSHOT:compile
[INFO] |  +- org.springframework.data:spring-data-redis:jar:2.4.3:compile
[INFO] |  |  +- org.springframework.data:spring-data-keyvalue:jar:2.4.3:compile
[INFO] |  |  |  \- org.springframework.data:spring-data-commons:jar:2.4.3:compile
[INFO] |  |  +- org.springframework:spring-oxm:jar:5.3.3:compile
[INFO] |  |  +- org.springframework:spring-aop:jar:5.3.3:compile
[INFO] |  |  \- org.springframework:spring-context-support:jar:5.3.3:compile
[INFO] |  \- io.lettuce:lettuce-core:jar:6.0.2.RELEASE:compile
[INFO] |     +- io.netty:netty-common:jar:4.1.58.Final:compile
[INFO] |     +- io.netty:netty-handler:jar:4.1.58.Final:compile
[INFO] |     |  +- io.netty:netty-resolver:jar:4.1.58.Final:compile
[INFO] |     |  +- io.netty:netty-buffer:jar:4.1.58.Final:compile
[INFO] |     |  \- io.netty:netty-codec:jar:4.1.58.Final:compile
[INFO] |     +- io.netty:netty-transport:jar:4.1.58.Final:compile
[INFO] |     \- io.projectreactor:reactor-core:jar:3.4.2:compile
[INFO] |        \- org.reactivestreams:reactive-streams:jar:1.0.3:compile
[INFO] +- org.springframework.cloud:spring-cloud-config-client:jar:3.0.2-SNAPSHOT:compile
[INFO] |  +- org.springframework.boot:spring-boot-autoconfigure:jar:2.4.2-SNAPSHOT:compile
[INFO] |  +- org.springframework.cloud:spring-cloud-commons:jar:3.0.1-SNAPSHOT:compile
[INFO] |  +- org.springframework.cloud:spring-cloud-context:jar:3.0.1-SNAPSHOT:compile
[INFO] |  +- org.springframework:spring-web:jar:5.3.3:compile
[INFO] |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.11.4:compile
[INFO] |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.11.4:compile
[INFO] |  \- org.apache.httpcomponents:httpclient:jar:4.5.13:compile
[INFO] |     \- commons-codec:commons-codec:jar:1.15:compile
[INFO] +- org.springframework.boot:spring-boot-starter-actuator:jar:2.4.2-SNAPSHOT:compile
[INFO] |  +- org.springframework.boot:spring-boot-actuator-autoconfigure:jar:2.4.2-SNAPSHOT:compile
[INFO] |  |  +- org.springframework.boot:spring-boot-actuator:jar:2.4.2-SNAPSHOT:compile
[INFO] |  |  \- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.11.4:compile
[INFO] |  \- io.micrometer:micrometer-core:jar:1.6.3:compile
[INFO] |     +- org.hdrhistogram:HdrHistogram:jar:2.1.12:compile
[INFO] |     \- org.latencyutils:LatencyUtils:jar:2.0.3:runtime
[INFO] +- org.springframework.boot:spring-boot-starter-web:jar:2.4.2-SNAPSHOT:compile
[INFO] |  +- org.springframework.boot:spring-boot-starter-json:jar:2.4.2-SNAPSHOT:compile
[INFO] |  |  +- com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.11.4:compile
[INFO] |  |  \- com.fasterxml.jackson.module:jackson-module-parameter-names:jar:2.11.4:compile
[INFO] |  +- org.springframework.boot:spring-boot-starter-tomcat:jar:2.4.2-SNAPSHOT:compile
[INFO] |  |  +- org.apache.tomcat.embed:tomcat-embed-core:jar:9.0.41:compile
[INFO] |  |  \- org.apache.tomcat.embed:tomcat-embed-websocket:jar:9.0.41:compile
[INFO] |  \- org.springframework:spring-webmvc:jar:5.3.3:compile
[INFO] |     \- org.springframework:spring-expression:jar:5.3.3:compile
[INFO] +- org.springframework.boot:spring-boot-starter-validation:jar:2.4.2-SNAPSHOT:compile
[INFO] |  +- org.glassfish:jakarta.el:jar:3.0.3:compile
[INFO] |  \- org.hibernate.validator:hibernate-validator:jar:6.1.7.Final:compile
[INFO] |     +- jakarta.validation:jakarta.validation-api:jar:2.0.2:compile
[INFO] |     +- org.jboss.logging:jboss-logging:jar:3.4.1.Final:compile
[INFO] |     \- com.fasterxml:classmate:jar:1.5.1:compile
[INFO] +- org.springframework.security:spring-security-crypto:jar:5.4.2:compile
[INFO] +- org.springframework.security:spring-security-rsa:jar:1.0.9.RELEASE:compile
[INFO] |  \- org.bouncycastle:bcpkix-jdk15on:jar:1.64:compile
[INFO] |     \- org.bouncycastle:bcprov-jdk15on:jar:1.64:compile
[INFO] +- org.springframework.vault:spring-vault-core:jar:2.3.0:compile
[INFO] |  +- org.springframework:spring-core:jar:5.3.3:compile
[INFO] |  |  \- org.springframework:spring-jcl:jar:5.3.3:compile
[INFO] |  +- org.springframework:spring-context:jar:5.3.3:compile
[INFO] |  \- org.springframework:spring-beans:jar:5.3.3:compile
[INFO] +- org.springframework.credhub:spring-credhub-core:jar:2.1.1.RELEASE:compile
[INFO] |  \- org.springframework.security:spring-security-oauth2-client:jar:5.4.2:compile
[INFO] |     +- com.nimbusds:oauth2-oidc-sdk:jar:8.23.1:compile
[INFO] |     |  +- com.github.stephenc.jcip:jcip-annotations:jar:1.0-1:compile
[INFO] |     |  +- com.nimbusds:content-type:jar:2.1:compile
[INFO] |     |  +- com.nimbusds:lang-tag:jar:1.4.4:compile
[INFO] |     |  \- com.nimbusds:nimbus-jose-jwt:jar:9.1.3:compile
[INFO] |     +- org.springframework.security:spring-security-core:jar:5.4.2:compile
[INFO] |     \- org.springframework.security:spring-security-oauth2-core:jar:5.4.2:compile
[INFO] +- org.eclipse.jgit:org.eclipse.jgit:jar:5.1.3.201810200350-r:compile
[INFO] |  +- com.jcraft:jsch:jar:0.1.55:compile
[INFO] |  +- com.jcraft:jzlib:jar:1.1.1:compile
[INFO] |  +- com.googlecode.javaewah:JavaEWAH:jar:1.1.6:compile
[INFO] |  \- org.slf4j:slf4j-api:jar:1.7.30:compile
[INFO] +- org.eclipse.jgit:org.eclipse.jgit.http.apache:jar:5.1.3.201810200350-r:compile
[INFO] |  \- org.apache.httpcomponents:httpcore:jar:4.4.14:compile
[INFO] +- org.yaml:snakeyaml:jar:1.27:compile
[INFO] +- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:jar:2.11.4:compile
[INFO] |  \- com.fasterxml.jackson.core:jackson-core:jar:2.11.4:compile
[INFO] +- org.tmatesoft.svnkit:svnkit:jar:1.10.1:compile
[INFO] |  +- de.regnis.q.sequence:sequence-library:jar:1.0.4:compile
[INFO] |  +- org.tmatesoft.sqljet:sqljet:jar:1.1.12:compile
[INFO] |  |  \- org.antlr:antlr-runtime:jar:3.4:compile
[INFO] |  +- net.java.dev.jna:jna:jar:4.1.0:compile
[INFO] |  +- net.java.dev.jna:jna-platform:jar:4.1.0:compile
[INFO] |  +- com.trilead:trilead-ssh2:jar:1.0.0-build222:compile
[INFO] |  +- com.jcraft:jsch.agentproxy.connector-factory:jar:0.0.7:compile
[INFO] |  |  +- com.jcraft:jsch.agentproxy.core:jar:0.0.7:compile
[INFO] |  |  +- com.jcraft:jsch.agentproxy.usocket-jna:jar:0.0.7:compile
[INFO] |  |  |  \- net.java.dev.jna:platform:jar:3.4.0:compile
[INFO] |  |  +- com.jcraft:jsch.agentproxy.usocket-nc:jar:0.0.7:compile
[INFO] |  |  +- com.jcraft:jsch.agentproxy.sshagent:jar:0.0.7:compile
[INFO] |  |  \- com.jcraft:jsch.agentproxy.pageant:jar:0.0.7:compile
[INFO] |  +- com.jcraft:jsch.agentproxy.svnkit-trilead-ssh2:jar:0.0.7:compile
[INFO] |  \- org.lz4:lz4-java:jar:1.4.1:compile
[INFO] +- com.amazonaws:aws-java-sdk-core:jar:1.11.903:compile
[INFO] |  +- commons-logging:commons-logging:jar:1.1.3:compile
[INFO] |  +- software.amazon.ion:ion-java:jar:1.0.2:compile
[INFO] |  +- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.11.4:compile
[INFO] |  \- joda-time:joda-time:jar:2.8.1:compile
[INFO] +- com.amazonaws:aws-java-sdk-s3:jar:1.11.903:compile
[INFO] |  +- com.amazonaws:aws-java-sdk-kms:jar:1.11.903:compile
[INFO] |  \- com.amazonaws:jmespath-java:jar:1.11.903:compile
[INFO] +- org.springframework.boot:spring-boot-autoconfigure-processor:jar:2.4.2-SNAPSHOT:compile
[INFO] +- com.google.apis:google-api-services-iam:jar:v1-rev20201112-1.30.10:compile
[INFO] |  \- com.google.api-client:google-api-client:jar:1.30.10:compile
[INFO] |     \- com.google.oauth-client:google-oauth-client:jar:1.31.0:compile
[INFO] +- com.google.auth:google-auth-library-oauth2-http:jar:0.22.0:compile
[INFO] |  +- com.google.auto.value:auto-value-annotations:jar:1.7.4:compile
[INFO] |  +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
[INFO] |  +- com.google.auth:google-auth-library-credentials:jar:0.22.0:compile
[INFO] |  +- com.google.http-client:google-http-client:jar:1.37.0:compile
[INFO] |  |  +- com.google.j2objc:j2objc-annotations:jar:1.3:compile
[INFO] |  |  +- io.opencensus:opencensus-api:jar:0.24.0:compile
[INFO] |  |  |  \- io.grpc:grpc-context:jar:1.22.1:compile
[INFO] |  |  \- io.opencensus:opencensus-contrib-http-util:jar:0.24.0:compile
[INFO] |  +- com.google.http-client:google-http-client-jackson2:jar:1.37.0:compile
[INFO] |  \- com.google.guava:guava:jar:29.0-android:compile
[INFO] |     +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |     +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] |     +- org.checkerframework:checker-compat-qual:jar:2.5.5:compile
[INFO] |     \- com.google.errorprone:error_prone_annotations:jar:2.3.4:compile
[INFO] +- com.h2database:h2:jar:1.4.200:test
[INFO] +- org.springframework.boot:spring-boot-starter-test:jar:2.4.2-SNAPSHOT:test
[INFO] |  +- org.springframework.boot:spring-boot-test:jar:2.4.2-SNAPSHOT:test
[INFO] |  +- org.springframework.boot:spring-boot-test-autoconfigure:jar:2.4.2-SNAPSHOT:test
[INFO] |  +- com.jayway.jsonpath:json-path:jar:2.4.0:test
[INFO] |  |  \- net.minidev:json-smart:jar:2.3:compile
[INFO] |  |     \- net.minidev:accessors-smart:jar:1.2:compile
[INFO] |  |        \- org.ow2.asm:asm:jar:5.0.4:compile
[INFO] |  +- jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.3:test
[INFO] |  |  \- jakarta.activation:jakarta.activation-api:jar:1.2.2:test
[INFO] |  +- org.assertj:assertj-core:jar:3.18.1:test
[INFO] |  +- org.hamcrest:hamcrest:jar:2.2:test
[INFO] |  +- org.junit.jupiter:junit-jupiter:jar:5.7.0:test
[INFO] |  |  +- org.junit.jupiter:junit-jupiter-api:jar:5.7.0:test
[INFO] |  |  +- org.junit.jupiter:junit-jupiter-params:jar:5.7.0:test
[INFO] |  |  \- org.junit.jupiter:junit-jupiter-engine:jar:5.7.0:test
[INFO] |  +- org.mockito:mockito-core:jar:3.6.28:test
[INFO] |  |  +- net.bytebuddy:byte-buddy:jar:1.10.19:test
[INFO] |  |  +- net.bytebuddy:byte-buddy-agent:jar:1.10.19:test
[INFO] |  |  \- org.objenesis:objenesis:jar:3.1:test
[INFO] |  +- org.mockito:mockito-junit-jupiter:jar:3.6.28:test
[INFO] |  +- org.skyscreamer:jsonassert:jar:1.5.0:test
[INFO] |  |  \- com.vaadin.external.google:android-json:jar:0.0.20131108.vaadin1:test
[INFO] |  +- org.springframework:spring-test:jar:5.3.3:test
[INFO] |  \- org.xmlunit:xmlunit-core:jar:2.7.0:test
[INFO] +- org.junit.vintage:junit-vintage-engine:jar:5.7.0:test
[INFO] |  +- org.apiguardian:apiguardian-api:jar:1.1.0:test
[INFO] |  +- org.junit.platform:junit-platform-engine:jar:1.7.0:test
[INFO] |  |  +- org.opentest4j:opentest4j:jar:1.2.0:test
[INFO] |  |  \- org.junit.platform:junit-platform-commons:jar:1.7.0:test
[INFO] |  \- junit:junit:jar:4.13.1:test
[INFO] |     \- org.hamcrest:hamcrest-core:jar:2.2:test
[INFO] +- org.springframework.cloud:spring-cloud-test-support:jar:3.0.1-SNAPSHOT:test
[INFO] |  +- org.apache.maven.resolver:maven-resolver-connector-basic:jar:1.1.1:test
[INFO] |  |  +- org.apache.maven.resolver:maven-resolver-api:jar:1.1.1:test
[INFO] |  |  +- org.apache.maven.resolver:maven-resolver-spi:jar:1.1.1:test
[INFO] |  |  \- org.apache.maven.resolver:maven-resolver-util:jar:1.1.1:test
[INFO] |  +- org.apache.maven.resolver:maven-resolver-impl:jar:1.1.1:test
[INFO] |  +- org.apache.maven:maven-resolver-provider:jar:3.5.4:test
[INFO] |  |  +- org.apache.maven:maven-model:jar:3.5.4:test
[INFO] |  |  +- org.apache.maven:maven-model-builder:jar:3.5.4:test
[INFO] |  |  |  +- org.codehaus.plexus:plexus-interpolation:jar:1.24:test
[INFO] |  |  |  +- org.codehaus.plexus:plexus-component-annotations:jar:1.7.1:test
[INFO] |  |  |  +- org.apache.maven:maven-artifact:jar:3.5.4:test
[INFO] |  |  |  \- org.apache.maven:maven-builder-support:jar:3.5.4:test
[INFO] |  |  +- org.apache.maven:maven-repository-metadata:jar:3.5.4:test
[INFO] |  |  +- org.codehaus.plexus:plexus-utils:jar:3.1.0:test
[INFO] |  |  +- javax.inject:javax.inject:jar:1:test
[INFO] |  |  \- org.apache.commons:commons-lang3:jar:3.11:test
[INFO] |  \- org.apache.maven.resolver:maven-resolver-transport-http:jar:1.1.1:test
[INFO] +- org.eclipse.jgit:org.eclipse.jgit.junit.http:jar:5.1.3.201810200350-r:test
[INFO] |  +- org.eclipse.jgit:org.eclipse.jgit.http.server:jar:5.1.3.201810200350-r:test
[INFO] |  +- org.eclipse.jgit:org.eclipse.jgit.junit:jar:5.1.3.201810200350-r:test
[INFO] |  \- org.eclipse.jetty:jetty-servlet:jar:9.4.35.v20201120:test
[INFO] |     +- org.eclipse.jetty:jetty-security:jar:9.4.35.v20201120:test
[INFO] |     |  \- org.eclipse.jetty:jetty-server:jar:9.4.35.v20201120:test
[INFO] |     |     +- javax.servlet:javax.servlet-api:jar:4.0.1:test
[INFO] |     |     +- org.eclipse.jetty:jetty-http:jar:9.4.35.v20201120:test
[INFO] |     |     \- org.eclipse.jetty:jetty-io:jar:9.4.35.v20201120:test
[INFO] |     \- org.eclipse.jetty:jetty-util-ajax:jar:9.4.35.v20201120:test
[INFO] |        \- org.eclipse.jetty:jetty-util:jar:9.4.35.v20201120:test
[INFO] \- it.ozimov:embedded-redis:jar:0.7.3:test
[INFO]    +- commons-io:commons-io:jar:2.5:test
[INFO]    \- org.slf4j:slf4j-simple:jar:1.7.30:test
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.148 s
[INFO] Finished at: 2021-01-21T17:17:02-05:00
[INFO] Final Memory: 33M/605M
[INFO] ------------------------------------------------------------------------

I wonder where that comes from?

spencergibb commented 3 years ago

Nor is it of spring-cloud-launcher-configserver

There was a mismatch in thin launcher and thin deployer b0709ec5ce02311e8c52880738918e863fb68006

spencergibb commented 3 years ago 
2021-01-21 17:40:11.700  INFO 119997 --- [           main] o.s.boot.loader.thin.PathResolver        : Extracting dependencies from: jar:file:/home/spencer/.m2/repository/org/springframework/cloud/launcher/spring-cloud-launcher-configserver/3.0.1-SNAPSHOT/spring-cloud-launcher-configserver-3.0.1-SNAPSHOT.jar!/, with profiles []
2021-01-21 17:40:11.703  INFO 119997 --- [           main] o.s.boot.loader.thin.PathResolver        : Searching for properties in: jar:file:/home/spencer/.m2/repository/org/springframework/cloud/launcher/spring-cloud-launcher-configserver/3.0.1-SNAPSHOT/spring-cloud-launcher-configserver-3.0.1-SNAPSHOT.jar!/
2021-01-21 17:40:11.705  INFO 119997 --- [           main] o.s.boot.loader.thin.PathResolver        : Extracting dependencies from: URL [jar:file:/home/spencer/.m2/repository/org/springframework/cloud/launcher/spring-cloud-launcher-configserver/3.0.1-SNAPSHOT/spring-cloud-launcher-configserver-3.0.1-SNAPSHOT.jar!/META-INF/maven/org.springframework.cloud.launcher/spring-cloud-launcher-configserver/pom.xml], with profiles []
...
2021-01-21 17:40:13.045  INFO 119997 --- [           main] o.s.boot.loader.thin.DependencyResolver  : Resolved: javax.servlet:servlet-api:2.5=/home/spencer/.m2/repository/javax/servlet/servlet-api/2.5/servlet-api-2.5.jar
spencergibb commented 3 years ago

@dsyer how do I exclude that with thin launcher? I tried the following in thin-*.properties but it didn't work.

exclusions.servlet-api: javax.servlet:servlet-api
spencergibb commented 3 years ago

Was editing the wrong files.