Attempting to start services that don't exist silently fails

spring-cloud / spring-cloud-cli

Spring Cloud CLI features

Apache License 2.0

155 stars 80 forks source link

Attempting to start services that don't exist silently fails #40

Closed mstine closed 7 years ago

mstine commented 7 years ago

Accidentally did this:

spring cloud kakfa configserver eureka

and thrashed for 10 minutes about why Kafka wasn't responding. Then I realized...

It would be great if you could validate that the requested services actually exist and fail fast.

spencergibb commented 7 years ago

I looked at this 5 times before I saw kakfa instead of kafka.

spencergibb commented 7 years ago

Given spring cloud foo bar:

2016-10-04 19:34:50.501 ERROR 49387 --- [           main] o.s.c.launcher.deployer.DeployerThread   : Error starting 'spring cloud'.

The following are not valid: 'foo,bar'. Please check the name(s) and try again.
Valid choices are: configserver,dataflow,eureka,h2,hystrixdashboard,kafka,zipkin.

mstine commented 7 years ago

Hah nice! Yeah, my issue description was intentional to let you feel the pain a bit. ;-)