spring-cloud / spring-cloud-commons

Common classes used in different Spring Cloud implementations
Apache License 2.0
704 stars 701 forks source link

Documentation: override-none property works in only bootstrap configuration #1264

Closed hojongs closed 1 year ago

hojongs commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

As mentioned in spring-cloud/spring-cloud-config#1856, override-none property is not working without bootstrap configuration. It was useful feature but can't be used without bootstrap configuration. It will be better to describe the information in the spring cloud documentation.

https://docs.spring.io/spring-cloud/docs/2022.0.4/reference/html/configprops.html

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

ryanjbaxter commented 1 year ago

This is already called out here https://docs.spring.io/spring-cloud-config/docs/4.0.4/reference/html/#_using_bootstrap_to_override_properties

hojongs commented 1 year ago

Oh, I overlooked that, great!

https://github.com/spring-cloud/spring-cloud-config/commit/599c0603fe8f34e3c43c59b10e08ceaebac629f4

That's been added since v3.1.7. (I read Spring Cloud Config documentation of version 3.0.x)

It will be better if the explanation is added to the comment of the override-none property.

hojongs commented 1 year ago

Thank you for reflecting quickly!