search

spring-cloud / spring-cloud-commons

Common classes used in different Spring Cloud implementations
Apache License 2.0
704 stars 700 forks source link

Fix Add a specific description of ServiceInstance is empty #1291

Closed RealBeBetter closed 10 months ago

RealBeBetter commented 10 months ago

If the ServiceInstance is empty, the prompt information is too crude, which will increase the difficulty of user investigation.

RealBeBetter commented 10 months ago

The following is the error when using:

image
RealBeBetter commented 10 months ago

Thanks, @RealBeBetter. This looks good, but can you please submit it against 3.1.x instead of main, like this we will include the change in all the supported versions. Also, please update the copyright entry on top of the file to say 2012-2023, since the file is being updated.

I have recreated a new Pull Request. Please check.

OlgaMaciaszek commented 10 months ago

To do that you need to make a change in your 3.1.x branch, not main. And then create the PR. from your 3.1.x to Spring Cloud 3.1.x.

RealBeBetter commented 10 months ago

To do that you need to make a change in your 3.1.x branch, not main. And then create the PR. from your 3.1.x to Spring Cloud 3.1.x.

Sorry, I have resubmitted this time. The address is: pull request

OlgaMaciaszek commented 10 months ago

Closing in favour of https://github.com/spring-cloud/spring-cloud-commons/pull/1297.