search

spring-cloud / spring-cloud-commons

Common classes used in different Spring Cloud implementations
Apache License 2.0
701 stars 697 forks source link

Default value of `spring.cloud.loadbalancer.retry.enabled` remains consistent #1321

Closed DanielLiu1123 closed 7 months ago

DanielLiu1123 commented 7 months ago

This PR addresses one issue: The default value for spring.cloud.loadbalancer.retry.enabled is true, but this has not been consistently applied in some code.

OlgaMaciaszek commented 7 months ago

Hello, @DanielLiu1123. Thank you for working on this PR. I have reviewed it. However, in this case, we will not be accepting it, since this behaviour is there on purpose, as stated in the docs. That's because while with the blocking implementations, there's a dependency that needs to be added to trigger the retry behaviour (Spring Retry), in the case of the non-blocking implementation, there's no such starter, as the retry implementation is part of reactor-core, and the flag is used to opt into it.