search

spring-cloud / spring-cloud-config

External configuration (server and client) for Spring Cloud
Apache License 2.0
1.95k stars 1.29k forks source link

Support for dashes in profiles broken #1069

Open deveth0 opened 6 years ago

deveth0 commented 6 years ago

I think this might be related to #384:

I've got an application 'foo' which supports two profiles: 'profile1' and 'pro-file2'.

Configuration is served by a configuration-server (Springboot v2.0.3) but this only works without the dash:

I build a demo project which demonstrates the issue: https://github.com/deveth0/spring-boot-config-dash

Do I miss something here or are dashes in profiles currently a problem? Thanks

ryanjbaxter commented 6 years ago

The fix for #384 only ended up adding support for dashes in the application name not the profile name. So support for dashes in the profile name was never added. (just to clarify this works fine when fetching the configuration just a problem with the json/yml/properties endpoints)

deveth0 commented 6 years ago

Thanks for this info, as I really like the option to debug config by direct access to the config-server, I think we'll go for underscores in our profiles.