search

spring-cloud / spring-cloud-config

External configuration (server and client) for Spring Cloud
Apache License 2.0
1.96k stars 1.29k forks source link

Settings to disable ConfigServer HealthIndicator failed #1294

Closed deeravi closed 5 years ago

deeravi commented 5 years ago

I am using spring cloud config server with git backup. Version Finchley.RC2 for spring cloud dependency. Git server is polled repeatedly and I tried using health.config.enabled=false on bootstrap.properties on config server and it doesn't seem to have any effect. I have referred to the other issues reported for the same but with no avail. Please help !

ryanjbaxter commented 5 years ago

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

deeravi commented 5 years ago

Attaching a snapshot of what's happening in the production environment -
image

spencergibb commented 5 years ago

The value is spring.cloud.config.server.health.enabled. Finchley.RC2 is not a supported version. The actual text is much preferred to screenshots.

deeravi commented 5 years ago

Thanks @spencergibb. What would be a better version ? Also, would this value be a part of both cloud config server as well as client ?

spencergibb commented 5 years ago

Finchley.SR3. This is config server only.

deeravi commented 5 years ago

I tried with Finchley.SR3 with the mentioned changes spring.cloud.config.server.health.enabled on config server. Tough luck. image

spencergibb commented 5 years ago

The actual text is much preferred to screenshots.

Those logs are from the config client, the mentioned property is for the server, not the client.

The value is indeed health.config.enabled.

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

deeravi commented 5 years ago

Hi @spencergibb, I have tried including health.config.enabled in config client (bootstrap.yml) as well to no avail.

spencergibb commented 5 years ago

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

Not sure how many times we need to ask.

deeravi commented 5 years ago

Hi all, Thanks all for your help. The changes that you suggested worked when placed within application.yml.