search

spring-cloud / spring-cloud-connectors

Library to let cloud applications connect to services
Apache License 2.0
185 stars 161 forks source link

Use explicit dependency to jackson #309

Closed Marx314 closed 4 years ago

Marx314 commented 4 years ago

This would let user use the specific version they want.

pivotal-issuemaster commented 4 years ago

@Marx314 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 4 years ago

@Marx314 Thank you for signing the Contributor License Agreement!

scottfrederick commented 4 years ago

@Marx314 Depending on Jackson like this makes it possible for applications using Spring Cloud Connectors to pull in a different version of Jackson that might not be compatible with what Connectors needs it to do. This was a common problem several years ago with libraries that depended on Jackson, which is why Jackson is shaded in the first place.

Making this change now has the potential to be backward-incompatible with previous releases of Connectors. This change would need to be released as a new major version to communicate the backward-incompatible nature. Since the project is in maintenance mode, we won't be publishing new major releases. The replacement Java CFEnv project does not shade Jackson.