spring-cloud / spring-cloud-connectors

Library to let cloud applications connect to services
Apache License 2.0
185 stars 161 forks source link

Refactor CF connector to be URI-based? #57

Closed chrylis closed 10 years ago

chrylis commented 10 years ago

I just faceplanted into CF's inability to (AFAICT) set tags on user-provided services, meaning Spring Cloud won't pick them up. However, the MongoDB handler, at least, simply provides credentials in credentials.uri. Any possibility of rolling over to just inspecting those URIs instead of routing them through tag filtering?

ramnivas commented 10 years ago

That is what we are doing as an option. For private cloud and other CF instances (and on public cloud Redis service), we need to support a tags, labels, and uri combination.

chrylis commented 10 years ago

If SC is detecting service type based on URI, why does it still filter by tag anyway instead of just always extracting credentials.uri?

ramnivas commented 10 years ago

There are services such as Redis (and more on private instances of Spring Cloud) where credentials.uri field isn't set.

chrylis commented 10 years ago

Ah, I'd only looked at a few of the creators, and they all just had the URIs. Looks like I can just set a custom service with credentials.uri=mongodb://user:pass@host:port/db, correct?

ramnivas commented 10 years ago

Correct.