search

spring-cloud / spring-cloud-connectors

Library to let cloud applications connect to services
Apache License 2.0
185 stars 161 forks source link

Relational DataSourceCreator doesn't support the Hikari connection pool #91

Closed jbcpollak closed 9 years ago

jbcpollak commented 10 years ago

Spring-boot supports the Hikari connection pool (see https://github.com/spring-projects/spring-boot/issues/418), but Spring-Cloud-Connectors does not. This causes problems when projects that use Hikari deploy to Coudfoundry or Heroku, resulting in this error message:

» 19:19:18.354 [localhost-startStop-1] WARN  o.s.c.s.relational.DataSourceCreator 
    - Found neither DBCP nor Tomcat connection pool on the classpath (no pooling is in effect).

I think it if Spring-boot supports Hikari, Spring-Cloud needs to also.

@brettwooldridge - FYI, thought you'd like to know.

jbcpollak commented 10 years ago

I've taken a first stab and implementing support:

https://github.com/AssuredLabor/spring-cloud-connectors/tree/HikariCP

Its untested as of yet but I'll report back when I get it going

brettwooldridge commented 10 years ago

@jbcpollak thanks for the heads up.

jbcpollak commented 10 years ago

I verified my implementation works, I'll create a pull request shortly.

jbcpollak commented 10 years ago

I created PR https://github.com/spring-cloud/spring-cloud-connectors/pull/92.

@brettwooldridge - thanks for the awesome work.

scottfrederick commented 9 years ago

Fixed via #92.