Consider replacing https://github.com/Ecwid/consul-api with Interface Clients

spring-cloud / spring-cloud-consul

Spring Cloud Consul

http://cloud.spring.io/spring-cloud-consul/

Apache License 2.0

813 stars 541 forks source link

Consider replacing https://github.com/Ecwid/consul-api with Interface Clients #475

Open spencergibb opened 5 years ago

spencergibb commented 5 years ago

A move to non-blocking infrastructure like spring-cloud-loadbalancer will be problematic with a blocking client.

varnson commented 5 years ago

Is anyone working on consul-api with WebClient?

pturczyk commented 1 year ago

It seems that although Ecwid/consula-api is still listed on official consul API docs, it is not really actively maintained. Last release happened on Apr 9, 2020 and reported Issues are not being addressed nor commented.

Perhaps it's worth bringing up the topic of replacing the underlying Consul API again. Especially, as some API's has been deprecated and some new features like caching are not supported.

spencergibb commented 1 year ago

I would use the new Interface Clients from Spring Framework. It would make it easy to do both reactive and blocking.

alex-kormukhin commented 9 months ago

Consul token query parameter deprecated in Consul 1.17 #809

M-Whitaker commented 3 months ago

Is anyone working on this? Are you accepting PRs?

spencergibb commented 3 months ago

Not yet, PRs wecome

M-Whitaker commented 3 months ago

I’m happy to start to look at creating an interface client as suggested removing the lib from the config module.

M-Whitaker commented 3 months ago

@spencergibb Any comments on the current draft PR are most welcome to get some feedback on the implementation.

spencergibb commented 3 months ago

I will look when I have time

monwolf commented 1 month ago

@spencergibb it's still pending, are you planning to review this PR?

spencergibb commented 1 month ago

@monwolf as the PR stands, it will need to wait for our major in 2025.1 (Nov 2025) as it is a breaking change. If you want to make it opt-in, I can schedule it for 2025.0 (May 2025) and then we can remove the old one in 2025.1.