Open spencergibb opened 5 years ago
Is anyone working on consul-api with WebClient?
It seems that although Ecwid/consula-api is still listed on official consul API docs, it is not really actively maintained. Last release happened on Apr 9, 2020 and reported Issues are not being addressed nor commented.
Perhaps it's worth bringing up the topic of replacing the underlying Consul API again. Especially, as some API's has been deprecated and some new features like caching are not supported.
I would use the new Interface Clients from Spring Framework. It would make it easy to do both reactive and blocking.
Consul token query parameter deprecated in Consul 1.17 #809
Is anyone working on this? Are you accepting PRs?
Not yet, PRs wecome
I’m happy to start to look at creating an interface client as suggested removing the lib from the config module.
@spencergibb Any comments on the current draft PR are most welcome to get some feedback on the implementation.
I will look when I have time
@spencergibb it's still pending, are you planning to review this PR?
@monwolf as the PR stands, it will need to wait for our major in 2025.1 (Nov 2025) as it is a breaking change. If you want to make it opt-in, I can schedule it for 2025.0 (May 2025) and then we can remove the old one in 2025.1.
A move to non-blocking infrastructure like spring-cloud-loadbalancer will be problematic with a blocking client.