Consider reinstating tags-as-metadata option

spring-cloud / spring-cloud-consul

Spring Cloud Consul

http://cloud.spring.io/spring-cloud-consul/

Apache License 2.0

813 stars 541 forks source link

Open spencergibb opened 3 years ago

spencergibb commented 3 years ago

See #696 and #698. Please vote using the reaction feature of THIS comment.

spencergibb commented 3 years ago

@lucasoares PR?

lucasoares commented 3 years ago

@spencergibb I can make it.. I just forked to be able to fix my problem as fast as possible and after that I had no time to do it.

I will have to change the default value to false right?

spencergibb commented 3 years ago

@lucasoares yes, default to false.

lucasoares commented 3 years ago

Please validate my solution and inform me any remaining changes I need to do: #700

Thanks.

HaojunRen commented 3 years ago

That means spring.cloud.consul.discovery.metadata.version=1.0 and spring.cloud.consul.discovery.tags=version=1.0 are all supported?