search

spring-cloud / spring-cloud-consul

Spring Cloud Consul
http://cloud.spring.io/spring-cloud-consul/
Apache License 2.0
813 stars 541 forks source link

Reinstate tags-as-metadata adding option to merge tags. Fixes #699 #775

Open hamigam opened 2 years ago

hamigam commented 2 years ago

Picking up the work from https://github.com/spring-cloud/spring-cloud-consul/pull/700

I've brought back the missing constructor as mentioned in the review comments of PR 700. Additionally I've added support to start reading isSecure from tags when enabled - for full backwards compatibility.

I did not address the comments around ConfigServer - I see this PR as a compatibility bridge for services already deployed with older versions of Spring Boot, I see current scope of changes sufficient to achieve this goal?

Please be gentle, my first contribution to Spring.

hamigam commented 2 years ago

@spencergibb @ryanjbaxter could you guys have a look? Adding this backwards compatibility would help to upgrade Spring Boot in large enterprise deployments and, for example, cleanly remediate recently popular CVE-2022-22965. Thanks!

lucasoares commented 1 year ago

Any progress here? @spencergibb I will close #700 in favor of this one.