search

spring-cloud / spring-cloud-consul

Spring Cloud Consul
http://cloud.spring.io/spring-cloud-consul/
Apache License 2.0
808 stars 540 forks source link

allow key deletion to trigger configuration refresh #781

Open DanielYWoo opened 2 years ago

DanielYWoo commented 2 years ago

see https://github.com/spring-cloud/spring-cloud-consul/issues/780

Adding/changing a key triggers refreshing values for Environment and @value. But deleting a key does not. This is a strange behavior. e.g., you have two paths to watch in Consul: /default/config and /my-service/config, if I add a key to my-service/config I can override the default settings in /default/config, but when I delete the key, nothing happens and I have to restart my app.

Moreover, when I delete a key, in ConfigWatch.watchConfigKeyValues(), the index will stop increasing. Suppose you get an index 16866 previously, then for the deletion event we should increase the current index to the new index in the response, maybe 16914. Currently the watch just stops at 16866 and retry and retry over again. If you set timeout shorter to 3 second you will see this busy loop behavior from log. Without increasing the index, it's a little less efficient and we will waste some resources.

I think the problem is, when 404 with a higher index is returned, it means the key was deleted, and we should publish the RefreshEvent and increase the index. Then the spring config framework should listen to the event and change accordingly, maybe delete the key from ConsulPropertySource.

DanielYWoo commented 2 years ago

can somebody approve the initial code check workflow to run?

DanielYWoo commented 2 years ago

@spencergibb could you take a look and approve it?

DanielYWoo commented 2 years ago

@marcingrzejszczak @ryanjbaxter hi, could you take a look?

spencergibb commented 2 years ago

Please be patient

ryanjbaxter commented 2 years ago

I approved the checks, you have checkstyle errors

DanielYWoo commented 2 years ago

Hi Ryan, many thanks, I fixed checkstyle errors. BTW, the unit test currently has a minor problem on a slow machines, I also put a comment into the unit test.

DanielYWoo commented 2 years ago

@ryanjbaxter I am working on another PR, similar to this one, there are some checkstyle errors on some classes that I did not touch. I need to fix them even they are unrelated and untouched, right?

ryanjbaxter commented 2 years ago

I dont see how that would be possible, that would imply that there are checkstyle errors in the code and if that was the case our builds would be failing because of them. I just checked and our builds are all green.

DanielYWoo commented 2 years ago

@ryanjbaxter I am thinking exactly the same as you. Anyway, just curious but it's not a big deal, I have fixed them all in another PR.

spencergibb commented 1 year ago

I also think we are at odds with #223. What would be the difference between a prefix not existing and a key deletion?