search

spring-cloud / spring-cloud-consul

Spring Cloud Consul
http://cloud.spring.io/spring-cloud-consul/
Apache License 2.0
805 stars 543 forks source link

Make profile specific paths optional #788

Open DanielYWoo opened 2 years ago

DanielYWoo commented 2 years ago

As stated in https://github.com/spring-cloud/spring-cloud-consul/issues/787 we need to mitigate the pressure to Consul, so the change is to add a new flag to get rid of profiles in a large deployment.

The change is simple, now we have a flag spring.cloud.consul.config.profileEnabled, and default to true to keep it compatible with the current behavior. When disabled, we will scan less paths on Consul.

P.S. Many of the changes are due to checkstyle, not really related to this change. I have to fix them to make the build pass.

DanielYWoo commented 2 years ago

@ryanjbaxter If this is approved, how do I update the documents?

ryanjbaxter commented 2 years ago

I just approved the build to run I don't understand the checkstyle failures though