Closed stewartie4 closed 1 year ago
@stewartie4 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
@stewartie4 Thank you for signing the Contributor License Agreement!
Hi @ryanjbaxter I see you've triaged other PRs on this repo, is there anything else I need to do here? Thanks
There are checkstyle faiures
Thanks @ryanjbaxter, resolved
Check the build again
Apologies @ryanjbaxter I had maven repo issues locally so was relying on CI Didn't realise you would have to approve every single run. Passing locally now
Users of spring cloud consul may wish to further modify the consul client
Example modifications:
Today the builder is statically instantiated inside createConsulClient() therefore any modifications will require the user to copy and paste the boilerplate setup in createConsulClient(), then make modifications.
Extracting the client builder out to a separate bean allows a custom builder to be injected and therefore any modifications can be made without copy and pasting boilerplate code