spring-cloud / spring-cloud-consul

Spring Cloud Consul
http://cloud.spring.io/spring-cloud-consul/
Apache License 2.0
805 stars 543 forks source link

Extract consul client builder to distinct bean #790

Closed stewartie4 closed 1 year ago

stewartie4 commented 1 year ago

Users of spring cloud consul may wish to further modify the consul client

Example modifications:

Today the builder is statically instantiated inside createConsulClient() therefore any modifications will require the user to copy and paste the boilerplate setup in createConsulClient(), then make modifications.

Extracting the client builder out to a separate bean allows a custom builder to be injected and therefore any modifications can be made without copy and pasting boilerplate code

pivotal-cla commented 1 year ago

@stewartie4 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 1 year ago

@stewartie4 Thank you for signing the Contributor License Agreement!

stewartie4 commented 1 year ago

Hi @ryanjbaxter I see you've triaged other PRs on this repo, is there anything else I need to do here? Thanks

ryanjbaxter commented 1 year ago

There are checkstyle faiures

stewartie4 commented 1 year ago

Thanks @ryanjbaxter, resolved

ryanjbaxter commented 1 year ago

Check the build again

stewartie4 commented 1 year ago

Apologies @ryanjbaxter I had maven repo issues locally so was relying on CI Didn't realise you would have to approve every single run. Passing locally now

image