search

spring-cloud / spring-cloud-consul

Spring Cloud Consul
http://cloud.spring.io/spring-cloud-consul/
Apache License 2.0
813 stars 541 forks source link

Added status code 404 to ReregistrationPredicate #808

Closed attermann closed 1 year ago

attermann commented 1 year ago

Consul agent as of approximately v1.11.2 returns status code 404 on agent health check instead of status code 500. This change resulted in re-registration not taking place when expected. Adding status code 404 to the ReregistrationPredicate enables re-registration with both older and newer versions of Consul agent.

pivotal-cla commented 1 year ago

@attermann Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla commented 1 year ago

@attermann Thank you for signing the Contributor License Agreement!

spencergibb commented 1 year ago

Thanks for the contribution. Added a test in 6378b72526f1205d7634d58b0d7e9645622f1410