search

spring-cloud / spring-cloud-consul

Spring Cloud Consul
http://cloud.spring.io/spring-cloud-consul/
Apache License 2.0
804 stars 543 forks source link

Incorrect health check path registered with spring-boot-actuator 1.3 #88

Open bpgray opened 8 years ago

bpgray commented 8 years ago

When using spring-boot-actuator 1.3, the health endpoint is now nested under server.contextPath when management.port is set. Note that this is different behavior than with spring-boot-actuator 1.2.5, and potentially breaking. Regardless of the spring-boot-actuator version, spring-cloud-consul does not seem to consider the contextPath of the management endpoints. Considering the appropriate contextPath in ConsulLifecycle.createCheck could be helpful and reduce the need for configuration via properties.

spencergibb commented 8 years ago

So, you are asking to automate what is documented?

bpgray commented 8 years ago

Yes, it seems that I am asking to automate what is documented in the case of setting management.contextPath or server.contextPath to something other than null. This seems like a reasonable enhancement, given that in most cases we will know the health endpoint location if the contextPath is set, and therefore won't need the user to modify the healthCheckPath in the properties.

ezraroi commented 8 years ago

+1