search

spring-cloud / spring-cloud-contract

Support for Consumer Driven Contracts in Spring
https://cloud.spring.io/spring-cloud-contract
Apache License 2.0
720 stars 438 forks source link

Need support test web socket connections with Spring Cloud Contracts #752

Open mankoffs opened 6 years ago

mankoffs commented 6 years ago

Hi @marcingrzejszczak . As we discussed https://gitter.im/spring-cloud/spring-cloud-contract?at=5bc6f78de4b1d87dc792a453 , you could try to handle test web socket via sth like this https://stackoverflow.com/questions/43127591/wiremock-equivalent-for-websockets. Thx.

mankoffs commented 6 years ago

Hi @marcingrzejszczak , I just wanted to add, if it makes a difference we use spring-boot-starter-websocket in our services. Could you please tell, when you plan to take this issue approximately?

OlgaMaciaszek commented 6 years ago

Hello @mankoffs this is an interesting features proposal, but we need to take into account the users interest in features while planning backlog. If more users vote for this issue, we will add it to our backlog to analyze it and once we are done with the analysis, we will be able to provide a timeline.

mankoffs commented 6 years ago

Hello @OlgaMaciaszek , are there any updates about issue? I hope that's enough votes :)

marcingrzejszczak commented 6 years ago

I sense an organized voting ;)

andreeatitiriga commented 4 years ago

Hi @OlgaMaciaszek . Is there any update about this? Are you taking into account having this feature implemented in the following period? Thanks a lot!

hughwphamill commented 3 years ago

Would be useful to me too

JoshMart commented 1 year ago

Another vote for this. Has this fallen off the radar? How many votes do we need to get this looked at?

DevBadger commented 1 year ago

Over the past 10 years I have worked with different large organizations (Target, HenrySchein, ADP) to implement test strategies. I have advocated the benefits of spring-cloud-contract and helped implement the framework at each of these employers. I am now seeing the lack of websocket support actually hurting the case for using spring-cloud-contract for api testing as well.

There is a significant investment involved in teaching a large organization the contract-verifier DSL, the process flow for the consumer/producer devs and the wiremock engine that accompanies the stubs/mappings. With the rise of websockets, the conversation that now ensues after teach spring-cloud-contract is "That is really great! This could really help us. Can we use the same method to test our websocket endpoints?". I have to explain that it does not. This naturally leads to a discussion about how we will test our websocket endpoints. Then comes the question, "can't we just test our rest endpoints the same way we plan to test our websocket endpoints?"

This continues to lead to a much harder discussion about the cost of learning spring-cloud-contract and if it the benefit is worth the investment if we cannot implement a similar strategy for both rest endpoints and websockets. It has become frustrating enough that I have made multiple starting attempts to contribute to the spring-cloud-contract project so we can finally have websocket support but I just haven't had the bandwidth to offer.

I ask you to consider a few things when prioritizing this enhancement:

  1. there are typically only one or two people helping an organization setup and implement the overall testing strategy for an organization. The desire for and the impact from the lack of websocket support in your user base may be woefully underrepresented.
  2. the lack of existing solutions for websocket testing presents a unique opportunity to expand framework adoption
  3. the negative impact the lack of websocket support is having on existing adoption as the adoption of websockets increases
mdimond commented 1 year ago

This is a much needed feature. Websockets are becoming very mainstay and are really helpful for async. Can we please have this looked at?

marcingrzejszczak commented 1 year ago

We have limited resources, pull requests are more than welcome

mdimond commented 1 year ago

Understood. Do you know of anyone is actively working on this I could sync up with?

Matt

On Thu, Mar 9, 2023, 10:41 AM Marcin Grzejszczak @.***> wrote:

We have limited resources, pull requests are more than welcome

— Reply to this email directly, view it on GitHub https://github.com/spring-cloud/spring-cloud-contract/issues/752#issuecomment-1462484679, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLWRX5354XEJCZKXIIRQC3W3II33ANCNFSM4F4NZECA . You are receiving this because you commented.Message ID: @.***>

marcingrzejszczak commented 1 year ago

Noone is actively working on this feature however if you want to work on it I can help you out and discuss things with you