Fix environment variables for platform account properties

sabbyanandan commented 5 years ago

As a user, I'm attempting to retry limiting_concurrent_task_executions sample locally in my environment; however, I'm unable to override the default limit of 20.

Issues:

[ ] The env-var SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_LOCAL_ACCOUNTS[DEFAULT].MAXIMUM_CONCURRENT_TASKS 3 includes ., which is wrong. It should be _ instead.
[ ] The env-var SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_LOCAL_ACCOUNTS[DEFAULT].MAXIMUM_CONCURRENT_TASKS 3 is missing _DEPLOYMENT prefix.
[ ] The correct env-var should be SPRING_CLOUD_DATAFLOW_TASK_PLATFORM_LOCAL_ACCOUNTS[DEFAULT]_DEPLOYMENT_MAXIMUMCONCURRENTTASKS 3.
[ ] Once when we update the sample/docs, we would have to then amend the Microsite demo with the correct property, too. (See limiting-concurrent-task-executions)
[ ] Update SCDF ref. guide to point to the correct property. (See docs)

dturanski commented 5 years ago

Does uppercase 'DEFAULT' work for you? I Thought the account name is case sensitive.

dturanski commented 5 years ago

@sabbyanandan - This is also wrong: https://dataflow.spring.io/docs/installation/cloudfoundry/cf-cli/

should be ...CONNECTION_SKIPSSLVALIDATION

dturanski commented 5 years ago

and here https://docs.spring.io/spring-cloud-skipper/docs/current/reference/htmlsingle/#skipper-installation-cloudfoundry

spring-cloud / spring-cloud-dataflow-samples

Fix environment variables for platform account properties #108