Migrate Kubernetes Schedules

spring-cloud / spring-cloud-dataflow-samples

Sample starter applications and code for use with the Spring Cloud Data Flow project

http://cloud.spring.io/spring-cloud-dataflow/

223 stars 205 forks source link

Migrate Kubernetes Schedules #134

Closed cppwfs closed 4 years ago

cppwfs commented 4 years ago

Migrates schedules that use SchedulerTaskLauncher and have the name in the format scheduleName-scdf-taskdefname to a schedule in which the platform launches the schedule directly.

chrisjs commented 4 years ago

i installed SCDF 2.4.0, created a task, created a schedule, saw it run the tasks on schedule. then updated to SCDF 2.5.0.BUILD-SNAPSHOT image for SCDF, ran the migration tool and saw the task get migrated properly, a new cronjob object created, etc. tasks were running and being cleaned up as expected. deleting the schedule for that task appears to have worked correctly as well

one thing to note that may or may not be considered for this migration is the option to cleanup all the pods the TL left behind

so from a k8s standpoint, things seem to work as expected

@ilayaperumalg any additions or feedback on CF?

cppwfs commented 4 years ago

Updated the PR based @chrisjs comments as well as those we discussed today. I will add the pod cleanup improvement in a later commit.

ilayaperumalg commented 4 years ago

Verified both the K8s and PCF using 2.3.0.RELEASE as the base.

Created simple and composed tasks
Ran the migration tool for all vs single schedule name
Verified the migration changes: K8s: The cronjobs now schedules the apps directly CF: the schedule launcher app got deleted and the PCF scheduler now schedules the apps directly.

chrisjs commented 4 years ago

merged in 48434d7e6140c48469e7f5aaaeca4ba48fc1b481