search

spring-cloud / spring-cloud-dataflow-samples

Sample starter applications and code for use with the Spring Cloud Data Flow project
http://cloud.spring.io/spring-cloud-dataflow/
220 stars 203 forks source link

Inventory the samples we should support (delete the irrelevant/unwanted ones) #169

Open onobc opened 2 years ago

onobc commented 2 years ago

Proposed inventory below.

A good next step would be to go through the docs (Microsite, etc...) and be sure that none of the samples in the "to delete" category are referenced in the docs. And if they are referenced and we still want to drop support - then remove them from the docs.

onobc commented 2 years ago

Original list proposed by @cppwfs

Keep:

✅ transition-sample ✅ timestamp-task ✅ timestamp-batch ✅ scenario-task ✅ monitoring-samples ✅ kafka-samples ✅ security-ldap-uaa-example ✅ java-dsl ✅ function-samples ✅ dataflow-website ✅ dataflow-template-example ✅ file-ingest

Discuss

? spring-cloud-stream-function-bindings (refer them to the spring cloud stream apps?) ? dataflow-template-load-generator ? keystore ? multi-io-samples ? keystore ? dataflow-zuul ? custom-dataflow-builds

Discard:

❌ dataflow-migrate-schedules

onobc commented 2 years ago

With my recent updates to the SCDF ref guid and Microsite...

The Microsite and/or SCDF ref guide references only these:

I'm not sure exactly how these are referenced but I am pretty sure they are used (we just moved them over here)

This is reference in SCDF /Users/cbono/repos/spring-cloud-dataflow/src/docker-compose/docker-compose-ssl.yml ​

ℹ️ The above items should be the only ones considered "active" in this repo and therefore they should be kept up-to-date w/ versions etc..

These are not being used/referenced anywhere now - we should leave them in the repo for now but mark them loudly as deprecated/read-only in the top-level-readme as well as at the top of each of their readme.

Additionally, our CI is building and publishing these but nobody is referencing them. We should remove them from CI if we move forward w/ these being "deprecated":