spring-cloud / spring-cloud-dataflow-ui

This repo provides the Dashboard application of Spring Cloud Data Flow
https://dataflow.spring.io/
Apache License 2.0
207 stars 117 forks source link

UI Applications must show all (default and non-default) applications #1640

Open tzolov opened 3 years ago

tzolov commented 3 years ago

Currently the applications that don't have at lest one version set as default are not show in the application list.

At the same time the shell's app list as well as the SCDF Rest (http://<scdf-server>:9393/apps) show that the applications are registered.

To reproduce:

As a result the UI will un-register all default apps. But will stop showing the non-default apps. If you use the shell app list or rest http://:9393/apps you will see that the 3.x apps are still registered just the UI doesn't show them.

If you use the shell to an 3.x app to default then it will appear on the UI as well.

tzolov commented 3 years ago

As additional observation and discrepancy : The shell app all unregister unregisters all apps (default and non-default). While the UI unregisters only the default such.

sabbyanandan commented 3 years ago

Some observations:

1) Shell/API vs. GUI discrepancy.

2) Once when a default version is unregistered, we need to either allow it only when a new version is selected or prevent it to avoid the desprecancy.

3) If a default version is inregistered, we could automatically pick a new default.