search

spring-cloud / spring-cloud-dataflow-ui

This repo provides the Dashboard application of Spring Cloud Data Flow
https://dataflow.spring.io/
Apache License 2.0
214 stars 118 forks source link

The local storage check for the Reverse-Proxy-Feature is made against boolean not string #2015

Open klopfdreh opened 1 month ago

klopfdreh commented 1 month ago

We updated to SCDF 2.11.5 and there was a small mistake I made for the check if the Reverse-Proxy-Feature is enabled.

See: https://github.com/spring-cloud/spring-cloud-dataflow-ui/blob/v3.4.6/ui/src/app/shared/api/task.service.ts#L269

it should be

UrlUtilities.fixReverseProxyUrl(url, this.localStorageService.get('reverseProxyFixActiveValue') === 'true'),

I am going to create a fix PR.