search

spring-cloud / spring-cloud-dataflow

A microservices-based Streaming and Batch data processing in Cloud Foundry and Kubernetes
https://dataflow.spring.io
Apache License 2.0
1.11k stars 580 forks source link

Log WARN message when retrieving step-execution details for pre-Batch 4.0 applications #2665

Open cppwfs opened 5 years ago

cppwfs commented 5 years ago

With Boot 2 and Batch 4 the default serializer was updated and thus if SCDF 2.x tries to read a Batch Execution Context from Pre Spring Batch 4.0 will fail. SCDF may need to be able to read both Jackson and XStream serialized contexts.

Looking at lines: https://github.com/spring-cloud/spring-cloud-dataflow/blob/master/spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/batch/SimpleJobServiceFactoryBean.java#L218-L224

We were using XStreamExecutionContextStringSerializer for Pre Batch 4.0 apps for(SCDF 1.7.x and before) . Now that we are on Batch 4.0+ we use Jackson2ExecutionContextStringSerializer, which will not work for Pre Batch 4.0. We need to be able to read both.

sabbyanandan commented 5 years ago

For Shell and the UI, for when there's no step execution details, we could show a user-friendly error message as to why.