spring-cloud / spring-cloud-dataflow

A microservices-based Streaming and Batch data processing in Cloud Foundry and Kubernetes
https://dataflow.spring.io
Apache License 2.0
1.11k stars 581 forks source link

Renaming k8s deployment/service prevent auto-scaling #5286

Open corneil opened 1 year ago

corneil commented 1 year ago

Description: HPA (Horizontal Pod Autoscaling) uses a Deployment name to configure scaling. If the Deployment name is modified when the user updates the deployment the HPA becomes invalid and needs to be updated.

Discussion Do we need to rename the Deployment and other artefacts when Kubernetes will rollout an update when the non-immutable part of the resource is updated?

Rollback

markpollack commented 1 year ago

The current design of skipper was based off ArgoCD and to a lesser extent Flux

markpollack commented 1 year ago

In a related note, can investigate supporting the TAS blue/green deployment feature now in TAS, which wasn't available when skipper was created.