search

spring-cloud / spring-cloud-dataflow

A microservices-based Streaming and Batch data processing in Cloud Foundry and Kubernetes
https://dataflow.spring.io
Apache License 2.0
1.11k stars 581 forks source link

User needs ability to specify app version when creating schedule #5830

Closed cppwfs closed 3 months ago

cppwfs commented 4 months ago

This update allows user to specify version.label=<version.number>.

Previously the version number specified was not used when searching the registry for the resource, thus the default version was used.

Tests were also updated because the original settings assumed that the AppRegistration was a real instance instead of being mocked. Thus the find would always return null. And in this case the tests returned a false positive. Now that the mocks are in place it exercises all the code. Also added explicit test if user does not set the version number. Some of the tests do this, but wanted an explicit test to verify this.

resolves #5705

cppwfs commented 3 months ago

Squashed Merged. @corneil Thanks for the review!