spring-cloud / spring-cloud-dataflow

A microservices-based Streaming and Batch data processing in Cloud Foundry and Kubernetes
https://dataflow.spring.io
Apache License 2.0
1.09k stars 579 forks source link

Migrate CTR to Boot 3.x and Batch 5.x #5839

Open cppwfs opened 2 weeks ago

cppwfs commented 2 weeks ago
cppwfs commented 2 weeks ago

I think we should proceed with this PR (after comments are resolved), but I want to revisit the JobLauncher here. I think we are still using the SyncTaskExecutor, which will work for now and will let us proceed to let us finish the build in this branch.
I will create a story on trello to revisit this.

cppwfs commented 2 weeks ago

Update: We don't need to override the JobLauncher. We can use the existing behavior. The executor I was worried about not being set is not used for the JobLauncher. It is currently being set for the job as it is created by the CTR.