spring-cloud / spring-cloud-deployer-cloudfoundry

The Spring Cloud Deployer implementation for Cloud Foundry
Apache License 2.0
28 stars 39 forks source link

SCDF deployer properties are not binding correctly to CF Deployer env property #355

Closed dturanski closed 4 years ago

dturanski commented 4 years ago

@dturanski commented on Wed Aug 26 2020

Description:

ROOT.LOG.LEVEL does not show up anywhere.

deployer.timestamp.useSpringApplicationJson=false
app.timestamp.environmentVariables=ROOT_LOG_LEVEL: DEBUG

still shows up in SAJ:

User-Provided:
SPRING_APPLICATION_JSON: {...,"spring.datasource.driverClassName":"org.mariadb.jdbc.Driver","ROOT_LOG_LEVEL":"DEBUG","spring.cloud.task.name":"task9"...}

Release versions: 2.6.x Custom apps: N/A

Steps to reproduce:

Screenshots: Where applicable, add screenshots to help explain your problem. image

Additional context: Add any other context about the problem here.

The property prefixes in the above example are incorrect. It should be

deployer.*.cloudfoundry.env.ROOT.LOG.LEVEL=DEBUG
deployer.*.cloudfoundry.use-spring-application-json=false

Nevertheless, the issue is legitimate.