search

spring-cloud / spring-cloud-deployer-kubernetes

The Spring Cloud Deployer implementation for Kubernetes
Apache License 2.0
157 stars 98 forks source link

feat: support volume mounts in init containers #409

Closed hfgbarrigas closed 3 years ago

hfgbarrigas commented 3 years ago

solves #357

pivotal-issuemaster commented 3 years ago

@hfgbarrigas Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 3 years ago

@hfgbarrigas Thank you for signing the Contributor License Agreement!

chrisjs commented 3 years ago

thank you for the contribution. before it can be reviewed, please revert all the formatting changes. we use tabs vs spaces.

hfgbarrigas commented 3 years ago

thank you for the contribution. before it can be reviewed, please revert all the formatting changes. we use tabs vs spaces.

Done. Looks like my formatting is a bit different and ended up adding more changes than necessary ... Let me know if you'd rather remove the formatting changes and just keep the functional changes.

chrisjs commented 3 years ago

yes; please revert the formatting changes and only include only your change bits (using tabs as formatting)

hfgbarrigas commented 3 years ago

done

chrisjs commented 3 years ago

thanks - merged in 557d7f70eeddb3bca21392ac2a81100194cdf7c7

hfgbarrigas commented 3 years ago

great - when is the next version released?

chrisjs commented 3 years ago

i don't have an exact date but should be going out soon. if you would like to use a current build artifact, for now the SNAPSHOT's are available