search

spring-cloud / spring-cloud-deployer-kubernetes

The Spring Cloud Deployer implementation for Kubernetes
Apache License 2.0
157 stars 98 forks source link

Migrates project to use Fabric8 5.3.0 [Do Not Merge] #429

Closed cppwfs closed 3 years ago

cppwfs commented 3 years ago

resolves #428

chrisjs commented 3 years ago

the original intent of this upgrade was to test out token expiration fixes that were made in later versions. while we noticed some improvement, the issue still remains.

given its not fully fixed and there is an upcoming release, we may consider first trying auth with an SA token instead of exec'ing to tmc. if that works, we should open an issue with fabric8 in hopes we can get a proper fix in, test and then upgrade preferably at the start of a release cycle

cppwfs commented 3 years ago

I will close this PR and we can handle the upgrade later.