spring-cloud / spring-cloud-deployer-kubernetes

The Spring Cloud Deployer implementation for Kubernetes
Apache License 2.0
157 stars 98 forks source link

Could not retrieve log from k8s Job in SCDF when job finished #468

Closed szopal closed 2 years ago

szopal commented 2 years ago

Hi,

I think it is bug because when we used k8s POD event if POD was finished logs were available, but when we change to k8s Job when Job is finished we get message:

Log could not be retrieved. Verify that deployments are still available.

SCDF v.2.9.0

When I get logs by kubectl logs -f pod-id it works.

jvalkeal commented 2 years ago

Moved to k8s deployer.

Looking this and I think issue is there https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/blob/57321c54fdd494b8534ddb7df0e0be3c7cd5fff0/src/main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesTaskLauncher.java#L198

jvalkeal commented 2 years ago

This was actually fixed in #463, closing in favour of #470.

szopal commented 2 years ago

Thanks. In which version SCDF this fix will be available?