search

spring-cloud / spring-cloud-deployer-kubernetes

The Spring Cloud Deployer implementation for Kubernetes
Apache License 2.0
157 stars 98 forks source link

Add integration tests for task cleanup (jobs and pods) #475

Closed onobc closed 2 years ago

onobc commented 2 years ago

Adds an integration test for task cleanup for both job and pod based tasks.

Motivated by https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/pull/473#issuecomment-1000327922

My original intent was to add a single test for the cleanup method. However, once I got into the code I saw an opportunity for refactoring a bit (explained inline in the review self-comments). I apologize in advance for the "extra" changes I have introduced. My intention was to layer it step/step in commits to illustrate the evolution more clearly. However, at some point I just kept coding and looked up and said "oops, I forgot to slow-step commit along the way".

cppwfs commented 2 years ago

LGTM

cppwfs commented 2 years ago

Squashed Merged

cppwfs commented 2 years ago

Thanks for the contribution!