search

spring-cloud / spring-cloud-deployer-kubernetes

The Spring Cloud Deployer implementation for Kubernetes
Apache License 2.0
157 stars 98 forks source link

Adds Minikube instructions back to README #488

Closed onobc closed 2 years ago

onobc commented 2 years ago

I recently wanted to run the ITs locally and was unable to get GKE going again (I managed to beat it into submission and get it running sometime back, but then my trial expired etc..). So I figured I would try my luck running against Minikube, going against the advice in the README to use GKE..

All testing is curently done against a GKE cluster. Minikube is no longer useful since we test some parts of the external IP features that a LoadBalancer service provides.

It worked fine. I then dug into the ci-it.yml to see what it was using for the ITs - it is also using Minikube?

I noticed that Minikube was replaced w/ GKE way back in 2017. Is this something that has since been shifted back to using Minikube but yet to get reflected in the README?

My concern is that getting contributors to run the ITs against a GKE cluster may be quite a burden whereas Minikube is simple and painless.

@jvalkeal @trisberg Thoughts?

trisberg commented 2 years ago

I think the primary reason for removing minikube was that it was difficult to provide reliable instructions for adding a LoadBalancer that worked across different OS and/or minikube drivers. That might have improved or we no longer require a LoadBalancer for the tests.

onobc commented 2 years ago

I think the primary reason for removing minikube was that it was difficult to provide reliable instructions for adding a LoadBalancer that worked across different OS and/or minikube drivers. That might have improved or we no longer require a LoadBalancer for the tests.

Makes sense. We must not require a LB for the tests.

jvalkeal commented 2 years ago

This is fine if it works.