search

spring-cloud / spring-cloud-deployer-kubernetes

The Spring Cloud Deployer implementation for Kubernetes
Apache License 2.0
157 stars 98 forks source link

Request to upgrade to k8s-client 5.x.x #493

Closed vikulaggarwal closed 2 years ago

vikulaggarwal commented 2 years ago

There have been several releases of k8s-client after 4.13.3. Please upgrade to k8s-client 5.x.x. It'll make it easier for consumers to avoid incompatibility issues while up-taking this libraryi.

I tried to use this library with k8s-client version 5.8.0, but there seems to be incompatibility with k8s-client 5.x.x.

lgraf commented 2 years ago

This is an issue when using org.springframework.cloud:spring-cloud-dependencies since as of the 2021.0.0release it pulls in io.fabric8:kubernetes-client:5.9

Edit As i see this should be already addressed and included in the 2.8.0 release.

corneil commented 2 years ago

2.8.0 does use fabric8:5.9

@onobc Do we need to do anything else?

onobc commented 2 years ago

@corneil thanks for verifying. @lgraf we will close this out w/ the understanding that it is fixed in 2.8.0 release. Feel free to re-open if you find otherwise. Thanks for the report.