search

spring-cloud / spring-cloud-deployer-kubernetes

The Spring Cloud Deployer implementation for Kubernetes
Apache License 2.0
157 stars 97 forks source link

Add ttlSecondsAfterFinished cronjob spec to KubernetesScheduler #530

Closed angelzard83 closed 1 year ago

angelzard83 commented 1 year ago

Added ttlSecondsAfterFinished setting to automatically delete jobs when creating cronjob in spring-cloud-dataflow.

angelzard83 commented 1 year ago

@onobc Thank you for your review. I added the ttlSecondsAfterFinished property to the deployer properties CronConfig object and removed the pattern check and more tests as you reviewed. I think that ttlSecondsAfterFinished property should be null as default property because it is optional property. Please give me more review to this committed code.

onobc commented 1 year ago

Nice work @angelzard83 ! Thanks again for the contribution and also for the follow up doc PR in dataflow - much appreciated.

onobc commented 1 year ago

Closing via https://github.com/spring-cloud/spring-cloud-deployer-kubernetes/commit/d76a971a839a8c05208e0acac771d94e9c33458e